Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Artifact Builder Service in aggregator #906

Merged
merged 11 commits into from
May 9, 2023
Merged

Use Artifact Builder Service in aggregator #906

merged 11 commits into from
May 9, 2023

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented May 5, 2023 •
edited
Loading

Content

This PR includes the use of the Artifact Builder Service by the aggregator runtime to compute an artifact given a signed entity type and persist its associated signed entity

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Closes #869

@jpraynaud jpraynaud self-assigned this May 5, 2023
@jpraynaud jpraynaud requested review from ghubertpalo and Alenar May 5, 2023 15:05
@jpraynaud jpraynaud changed the base branch from main to ensemble/854-use-signable-builder-service-signer May 5, 2023 15:06
@github-actions
Copy link

github-actions bot commented May 5, 2023 •
edited
Loading

Test Results

    3 files  ±0    30 suites  ±0   7m 1s ⏱️ + 1m 37s
571 tests ±0  571 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
647 runs  ±0  647 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit ff2d661. ± Comparison against base commit c5ca321.

This pull request removes 2 and adds 2 tests. Note that renamed tests count towards both. 
runtime::runner::tests ‑ test_create_snapshot_archive_name_archive_after_beacon
runtime::runner::tests ‑ test_remove_snapshot_archive_after_upload

artifact_builder::mithril_stake_distribution::tests ‑ hash_value_doesnt_change_if_signers_order_change
artifact_builder::mithril_stake_distribution::tests ‑ sort_given_signers_when_created

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud temporarily deployed to testing-preview May 5, 2023 15:22 — with GitHub Actions Inactive
Base automatically changed from ensemble/854-use-signable-builder-service-signer to main May 9, 2023 07:58
@jpraynaud jpraynaud force-pushed the jpraynaud/869-use-artifact-builder-service-aggregator branch from 1176530 to ff2d661 Compare May 9, 2023 09:45
@jpraynaud jpraynaud temporarily deployed to testing-preview May 9, 2023 09:55 — with GitHub Actions Inactive
@jpraynaud jpraynaud merged commit cbf035d into main May 9, 2023
@jpraynaud jpraynaud deleted the jpraynaud/869-use-artifact-builder-service-aggregator branch May 9, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alenar Alenar Alenar approved these changes

@ghubertpalo ghubertpalo Awaiting requested review from ghubertpalo

Assignees

@jpraynaud jpraynaud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adapt runtime to use artifact builder service in aggregator
2 participants
@jpraynaud @Alenar